Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prettier and ESlint with pre-commit #37

Merged
merged 9 commits into from
Oct 12, 2021
Merged

Add prettier and ESlint with pre-commit #37

merged 9 commits into from
Oct 12, 2021

Conversation

sandhyak-tech
Copy link
Contributor

No description provided.

@sandhyak-tech
Copy link
Contributor Author

issue #10

thamaraiselvam
thamaraiselvam approved these changes Oct 10, 2021
View reviewed changes
.eslintrc.json Outdated Show resolved Hide resolved
@thamaraiselvam thamaraiselvam mentioned this pull request Oct 10, 2021
Open
@thamaraiselvam
Copy link
Owner

@sandhyak-tech Please also resolve conflicts

@sandhyak-tech
Copy link
Contributor Author

@thamaraiselvam conflicts resolved 👍 . Could u plz mark it as accepted

@thamaraiselvam thamaraiselvam merged commit 82c6e2e into thamaraiselvam:master Oct 12, 2021
@thamaraiselvam thamaraiselvam mentioned this pull request Oct 13, 2021
Closed
@sandhyak-tech
Copy link
Contributor Author

sandhyak-tech commented Oct 14, 2021 •
edited
Loading

Could u plz add hactoberfest-accepted tag to the PR

@thamaraiselvam
Copy link
Owner

It isn't necessary to add hactoberfest tag. By default all PRs will be accepted but you have to wait for 14 days to get PR mature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thamaraiselvam thamaraiselvam thamaraiselvam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandhyak-tech @thamaraiselvam