[TH2-4971] Add group into message ID in transport response #59
+263
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikita-Smirnov-Exactpro
approved these changes
Sep 6, 2023
Member
Nikita-Smirnov-Exactpro
left a comment
Nikita-Smirnov-Exactpro
left a comment
There was a problem hiding this comment.
Are we sure about change string format of message id? We were going to migrate rpt-viewer to ldp some day
Contributor
Author
Were we, @Nikita-Smirnov-Exactpro?) First time I've heard that. The current approach with groups (and disabling storing messages by alias) does not give us any choice except to add the group to the message ID (otherwise, you cannot extract it from the cradle without dancing with a tambourine). So, this was a judgment call to add it to the message ID |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.