Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.3.2: Fix a deployment directory leak #1793

Merged
merged 11 commits into from
Mar 3, 2024
Merged

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Mar 2, 2024

🆑
Fixed an issue where stopping or rebooting the server could cause the previously used deployment directory to not properly get cleaned up.
/🆑

Also adds a bunch of logging to help detect the issue in the future.

Potentially fixes #1779

Mergine with [TGSDeploy]

@Cyberboss Cyberboss added Fix Fixes incorrect functionality Code Improvement Brush up on code standards Logging Adding, removing, or lack of informational log output Watchdog: Advanced Issue with the WindowsWatchdog or PosixWatchdog Release This is a release pull request labels Mar 2, 2024
@Cyberboss Cyberboss added this to the v6.3.2 milestone Mar 2, 2024
@Cyberboss Cyberboss linked an issue Mar 2, 2024 that may be closed by this pull request
@Cyberboss Cyberboss enabled auto-merge March 2, 2024 19:26
github-actions[bot]
github-actions bot previously approved these changes Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Merging #1793 (660b549) into master (cde1ea6) will increase coverage by 0.00%.
The diff coverage is 86.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1793   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         679      679           
  Lines      145950   145970   +20     
  Branches     3173     3172    -1     
=======================================
+ Hits       139385   139413   +28     
+ Misses       6078     6070    -8     
  Partials      487      487           

github-actions[bot]
github-actions bot previously approved these changes Mar 2, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 3, 2024
@Cyberboss Cyberboss merged commit d36b852 into master Mar 3, 2024
100 checks passed
@Cyberboss Cyberboss deleted the TheHuntForRedOctober branch March 3, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Brush up on code standards Fix Fixes incorrect functionality Logging Adding, removing, or lack of informational log output Release This is a release pull request Watchdog: Advanced Issue with the WindowsWatchdog or PosixWatchdog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasionally deployments do not get cleaned due to lock leaks
1 participant