Add OpenDream support and SessionId
#1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Big |
Cyberboss
force-pushed
the
OpenDream
branch
2 times, most recently
from
ca76ce7
to
45a4498
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Cyberboss
force-pushed
the
OpenDream
branch
2 times, most recently
from
d4e01a5
to
eaa3bad
Compare
Done squashing commits
Drop support for custom OD repositories, hopefully fix custom installs. Need to go back to the git strat because of submodules
Also, report checkout progress
…D repo manager Various other things to get it compiling
src/Tgstation.Server.Host/Components/Engine/ByondInstallerBase.cs
Dismissed
Show dismissed
Hide dismissed
src/Tgstation.Server.Host/Components/Engine/EngineManager.cs
Dismissed
Show dismissed
Hide dismissed
src/Tgstation.Server.Host/Components/Engine/ByondInstallerBase.cs
Dismissed
Show dismissed
Hide dismissed
src/Tgstation.Server.Host/Components/Engine/ByondInstallerBase.cs
Dismissed
Show dismissed
Hide dismissed
src/Tgstation.Server.Host/Components/Engine/ByondInstallerBase.cs
Dismissed
Show dismissed
Hide dismissed
- Make use of `world.opendream_topic_port` in DMAPI if present. Send in initial bridge request. - Implement compiler and server arguments for `OpenDreamInstallation`. - Deprecate bridge port update requests. - Prevent symlink swapping if not running a BYOND engine.
- Fix race condition with updating launch parameters. - Add additional logging. - Add integration tests
Also fixes logic error in `AdvancedWatchdog.HandleNewDmbAvailable` in the `EngineType.OpenDream` case.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑
TGS now supports running DreamMaker coded games with OpenDream, the open source reimplementation of BYOND. Note that TGS requires the dotnet SDK version supported by the OpenDream version you'd like to use alongside it's normal ASP.NET Core runtime to build it.
The repository cloning job now reports checkout progress.
Fixed rare DreamDaemon startup failure that may occur due to a lingering socket.
Event scripts containing "Byond" in their names have been updated to use "Engine" instead. Old names will continue function.
Socket bind tests will now retry for up to 5s before failing with an AddressInUse exception.
Added a workaround for a potential hang while recording process output.
/:cl:
🆑 HTTP API
There has been a major version bump to API version 10.
The entire
/Byondroute has been removed.Added new
/Engineroute and associated models. This has similar functions to the old/Byondroute while being engine agnostic so as to support OpenDream.InstancePermissionSet.byondRightshas been renamed toInstancePermissionSet.engineRights.CompileJobResponse.byondVersionchanged to newCompileJobResponse.engineVersionmodel.Added
DreamDaemonResponse.sessionIdwhich is a unique ID for the current server execution./:cl:
🆑 Nuget: Api
Performed all API 10 model changes.
/:cl:
🆑 Nuget: Client
Performed all API 10 client changes.
/:cl:
🆑 DreamMaker API
Various event names changed to be engine agnostic.
Corrected documentation that stated a
/datum/tgs_versionengine version would be returned to properly say they will be stringified.Added enums and function for retrieving the current engine version.
/:cl:
Closes #1577
Required:
Mixed line endings error in OD OpenDreamProject/OpenDream#1492/filenot a string OpenDreamProject/OpenDream#1497/world.Topic()leads to an invalid response OpenDreamProject/OpenDream#1396/Engineroute?