Remove container margins on smaller (unsupported) displays. #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole max-width thing has always been kinda silly. The chosen viewport sizes are always monitor widths which assumes that somebody isn't gonna have a browser window smaller than their monitor but they will. Be it vertical taskbars, or tiling window managers or just doing a windows 7 and up drag to the side split screen, this assumption just doesn't hold up. having the page have a width of 720px unless i can get the viewpoint to exactly 992px or higher is silly ya know?
None the less thats all bootstrap side, not us, so this will work for the primary case the bootstrap way shows its flaws.
For those of you with access, this is live on campbell's tgs on the v5.2.4 tag of my fork but should work just as well on current.
this is still not ideal:
but its better than this
(viewport of ~900px, 1024px portrait monitor with a vertical taskbar)