-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "3.0.0" #148
Revert "3.0.0" #148
Conversation
This reverts commit cd741e9.
do you have a stack trace? |
No, stack traces go to stdout/stderr which only tgsv5 will save to disk and the only tgsv5 server is on linux which doesn't have this issue. |
Then how do you know it's related to rust-g? |
i mean the stack trace from the minidump |
the timing matches up with the first 3.0.0 test merges and the fault offset shows up as rustg |
they were crashing on the 25th and earlier too though, in fact you can see crashes on reboots all through july. |
yes, randomly, not consistently. the crash rate goes from every few rounds to every round for sybil on the 18th, which is when the first test merge happened on sybil. |
If I had to guess it's something to do with native mysql rust-tls probably using more tokio and causing crashes on exit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverting a released version? lmao no just downgrade on tg
i can yank the release if you really are scared of people downloading it, but I encountered no real problems testing this locally and it's probably just the generic 'all crashes are blamed on rust-g due to open connections'
ya if you bothered to read the pr comments you'd know that its being blamed because the timing matches up. also my concerns when i open revert fix prs are always generally about fixing master, i can't pr to the release tab sorry but master on this repo should at least try to be stable |
what comments, how am i supposed to know? tgstation/tgstation/pull/77307 has nothing and tgstation/tgstation/pull/76663 has nothing, and neither are linked here do you mean this PR? I'm just reinforcing what oranges said |
this isn't how you fix versioned packages. The right answer would be a 3.0.1 which changes the cargo build script to use nativetls again. But the problem is there's no definitive cause for the issue and i can't get enough information from the dmp file to actually determine what the root cause is. |
byond has fixed the reconnect topic bug so crashing during restart is no longer a concern for pop counts. also this might be fixed. |
Reverts #147
Makes the server crash on round restart on windows.
This kills pop counts because people don't always reconnect and its common for players to decide to end a play session if they meet the slightest resistance.