Prevents Fallen jobs from talking over radios, adds a fallen job helper #16242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
Code Improvement
|
very bandaid and assuming the talker will be human |
Lumipharon
requested changes
Jul 3, 2024
Comment on lines
+256
to
+258
| var/mob/living/carbon/human/talker = talking_movable | ||
| if(isfallenjob(talker.job)) // prevents any of the valhalla jobs from talking to the living | ||
| return |
There was a problem hiding this comment.
yeah this is omega snowflake, don't do this.
There was a problem hiding this comment.
Would it be better to make it var/mob/living/talker, or var/mob/living/carbon/talker? Unless you're specifically talking about the isfallenjob helper.
There was a problem hiding this comment.
If you don't want people in valhalla talking on radio, don't give them radios.
|
Alright, I created a much better fix in #16244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Prevents fallen jobs from talking on radios at all, and adds an isfallenjob helper.
Why It's Good For The Game
Issues with fallen getting access to coms keeps popping up, so this should solve any current and future issues with this once and for all.
Changelog
馃啈
fix: Fallen can no longer use the radio
code: Added a isfallenjob helper
/:cl: