Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LV prop cleanup #16231

Merged
merged 8 commits into from
Jul 5, 2024
Merged

LV prop cleanup #16231

merged 8 commits into from
Jul 5, 2024

Conversation

Lumipharon
Copy link
Contributor

@Lumipharon Lumipharon commented Jul 2, 2024

About The Pull Request

Attempts to clean up some LV props.

Reorg some of the files, fix/improve code, and cleaned out huge amounts of dup/pointless lines.

Why It's Good For The Game

less insane dm files.

Changelog

🆑
code: Cleaned up some LV prop code
/:cl:

@tgstation-server tgstation-server added Sprites Changes to .dmi file. Code Improvement Changes for adhering to code standards and codebase maintainability. Map Edit One or more changes to .dmm files. labels Jul 2, 2024
Copy link
Contributor

@RipGrayson RipGrayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mapping portion of this PR would undo the changes done in #1622

@RipGrayson RipGrayson merged commit bf34844 into tgstation:master Jul 5, 2024
36 checks passed
github-actions bot added a commit that referenced this pull request Jul 5, 2024
@Lumipharon Lumipharon deleted the LV_prop_fix branch July 5, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Changes for adhering to code standards and codebase maintainability. Map Edit One or more changes to .dmm files. Sprites Changes to .dmi file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants