Adds radio blacklist for non radio tokens in use #16224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiviPlus
reviewed
Jul 2, 2024
code/datums/jobs/squads.dm
Outdated
| @@ -417,6 +417,7 @@ | |||
| GLOBAL_LIST_EMPTY_TYPED(custom_squad_radio_freqs, /datum/squad) | |||
| ///initializes a new custom squad. all args mandatory | |||
| /proc/create_squad(squad_name, squad_color, mob/living/carbon/human/creator) | |||
| var/radio_whitelist = list(MODE_KEY_BINARY = MODE_KEY_BINARY, MODE_KEY_R_HAND = MODE_KEY_R_HAND, MODE_KEY_L_HAND = MODE_KEY_L_HAND, MODE_KEY_INTERCOM = MODE_KEY_INTERCOM, MODE_KEY_DEPARTMENT , MODE_KEY_DEPARTMENT) | |||
Ldip999
changed the title
ivanmixo
requested changes
Jul 4, 2024
Co-authored-by: ivanmixo <[email protected]>
Co-authored-by: ivanmixo <[email protected]>
Co-authored-by: ivanmixo <[email protected]>
Co-authored-by: ivanmixo <[email protected]>
Co-authored-by: ivanmixo <[email protected]>
|
That was a much better way to do it, thank you, I learned lots! |
|
You should put the statement in brackets, byond is being annoying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds a blacklist of tokens that are already in use elsewhere other than the radio list
Why It's Good For The Game
Today I noticed that "Naptelek" has been assigned the :n token, which is already in use by binary, making command staff unable to use it. This adds various tokens to the blacklist that are already in use by other things.
Changelog
馃啈
fix: Fixes custom squads being assigned tokens that were already in use by non radio prefixes
/:cl: