-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space extinguishes fire #16197
base: master
Are you sure you want to change the base?
Space extinguishes fire #16197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sold on the good for the game part personally (plus: sun's on fire, it's in space, basically the same thing), but in terms of implementation this seems like it would fit better on the spacefreeze status specifically instead of the turf behavior.
If we are going with the reasoning that the sun is on fire, why does being in space freeze you? |
The sun is not "on fire". The sun is hot because of superheated fusion. Fire is oxygen reacting with carbon to form CO2. Fusion is Hydrogen fusing together to form helium. Fire cannot exist in space in this context because there isn't the necessary things to keep it going, there is no oxygen in the atmosphere to react with the carbon in your body and on your clothes. TL:DR, Ldip is right, if you are in space there should be no fire because fire cannot exist in a vacuum. |
Terragov outlawed gasses years ago, which means that all current fires are banned from requiring oxygen without a special permit. This is also why glacial planets are no longer allowed to chill marines via cold air. Space freezes you because the sun takes up all the heat from it, including yours if you're there. It's official lore, just ask kuro. |
soulless pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally don't resolve comments yourself, reviewers use them to make repeat viewing easier.
Still haven't added it to light spacefreeze, is that an intentional choice?
Sorry. I am new to github and didn't knew |
no more icyhot |
Co-authored-by: ivanmixo <[email protected]>
Co-authored-by: ivanmixo <[email protected]>
Was literally unplayable, thank you! |
About The Pull Request
"Cold vacuum" that "instantly freezes you" will now extinguishes fire
Why It's Good For The Game
Feels like an oversight that we apply spacefreeze onto mobs when they enter space but the fire keeps burning just fine in the infinite emptiness of space.
Changelog
🆑
balance: Space extinguishes fire
/:cl: