Windows + Frames can be attacked in help intent #16186
Open
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Quality of Life
|
This sounds awful. And from looking at the code, it doesn't even do what it says on the tin? It looks like attack procs will only execute if not on harm intent. |
XElectricX
reviewed
Jun 27, 2024
Comment on lines
+193
to
+194
| if(user.a_intent == INTENT_HARM) | ||
| return |
There was a problem hiding this comment.
Harm intent is handled on the parent call.
|
I dont get it whats the issue this is fixing |
|
I unno how this is QOL, it just makes it behave inconsistantly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Windows + Frames can be attacked in help intent
Why It's Good For The Game
QOL
Changelog
🆑
qol: Windows + Frames can be attacked in help intent
/:cl: