Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes overwatch being unable to select targets to OB #15876

Merged
merged 1 commit into from
May 17, 2024

Conversation

Notamaniac
Copy link
Contributor

@Notamaniac Notamaniac commented May 15, 2024

About The Pull Request

#15598 broke the ability to select laser targets for OB's
This probably needs a more comprehensive fix, alas staring at html makes my head ache.
And no, this doesn't let you OB on a marine cam, the selected_target var is checked to see whether it's an orbital beacon (bring back orbital beacons pls) or laser target

Why It's Good For The Game

I won't get yelled at by Alan or other FC's for not firing the OB as an AI

Changelog

🆑
fix: Overwatch can select laser targets to fire OB's again
/:cl:

@tgstation-server tgstation-server added the Fix Fixes an issue with the game. label May 15, 2024
@gpinrgrmoma
Copy link

Quick question, will this also fix the other things from #15877 ? Ik this was made before the report, only just now seen this, and wonder if it also causes the same issues

@Notamaniac
Copy link
Contributor Author

This should allow AI's to OB again, but calling evacs and distress is the responsbility of the communications console, not the overwatch console. As far as I'm aware, the comms console isn't bugged for AI's

@gpinrgrmoma
Copy link

Nah, comms console is bugged for AI as well, I just had a brainfart and forgot they were separated for a second, so they might be entirely separate issues

@Lumipharon Lumipharon merged commit 4e8816e into tgstation:master May 17, 2024
35 checks passed
github-actions bot added a commit that referenced this pull request May 17, 2024
@Notamaniac Notamaniac deleted the overwatch branch July 2, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fixes an issue with the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants