Fixes revive() causing you to be unable to shoot at unseen tiles #15860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiviPlus
approved these changes
May 14, 2024
Merged
|
I found the root issue so gonna close this in favour of #15864 but thank you for narrowing down to exactly where the issue was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Allows mobs to shoot at unseen tiles when revive() gets called on them. I'm going to admit, this was more of a game of 'call the missing proc that wasn't called in login()'. I don't fully understand why this works, and my only guess that is that the screenmob.client.screen = list() call in the show_hud() deletes these voids that can be shot at, and that calling add_click_catcher() readds them. This is me talking out of my ass though. No immediate bugs from testing though.
Fixes #15550
Why It's Good For The Game
You no longer need to reconnect when leaving robotic cradles or entering EORD from the round ending to shoot at unseen tiles.
Changelog
🆑
fix: Admin revives, the robotic cradle, and entering EORD via round end prefs should no longer cause you to be unable to shoot at unseen tiles
/:cl: