Ports tg's del the world unit test #13825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanmixo
added
the
Do Not Merge
tgstation-server
added
Code Improvement
ivanmixo
force-pushed
the
del-the-world
branch
from
16d0766
to
59e0faf
Compare
ivanmixo
force-pushed
the
del-the-world
branch
from
59e0faf
to
5cfec59
Compare
github-actions
bot
added
the
Merge Conflict
…-Corps into del-the-world
tgstation-server
removed
Merge Conflict
ivanmixo
force-pushed
the
del-the-world
branch
from
b47656b
to
b8a52be
Compare
ivanmixo
force-pushed
the
del-the-world
branch
from
47cb5b4
to
471f2fd
Compare
ivanmixo
removed
the
Do Not Merge
comfyorange
added a commit
that referenced
this pull request
Sep 6, 2023
comfyorange
added a commit
that referenced
this pull request
Sep 6, 2023
github-actions
bot
added
the
Merge Conflict
…-Corps into del-the-world
tgstation-server
removed
Merge Conflict
vvvv-vvvv
reviewed
Sep 9, 2023
comfyorange
added a commit
that referenced
this pull request
Sep 9, 2023
comfyorange
added a commit
that referenced
this pull request
Sep 9, 2023
comfyorange
added a commit
that referenced
this pull request
Sep 9, 2023
QualityVan
reviewed
Sep 9, 2023
comfyorange
added a commit
that referenced
this pull request
Sep 10, 2023
ivanmixo
force-pushed
the
del-the-world
branch
2 times, most recently
from
73beee2
to
ef3afce
Compare
github-actions
bot
added
the
Merge Conflict
…-Corps into del-the-world
tgstation-server
removed
the
Merge Conflict
comfyorange
added a commit
that referenced
this pull request
Sep 16, 2023
comfyorange
added a commit
that referenced
this pull request
Sep 16, 2023
comfyorange
added a commit
that referenced
this pull request
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Requires #13824
https://github.com/tgstation/tgstation/pull/57728/files
https://github.com/tgstation/tgstation/pull/58972/files
https://github.com/tgstation/tgstation/pull/59612/files <- main one
https://github.com/tgstation/tgstation/pull/62725/files
https://github.com/tgstation/tgstation/pull/63877/files
https://github.com/tgstation/tgstation/pull/69696/files <- small bit, this one should be ported fully but is out of scope
https://github.com/tgstation/tgstation/pull/74604/files
https://github.com/tgstation/tgstation/pull/75535/files
https://github.com/tgstation/tgstation/pull/77504/files
https://github.com/tgstation/tgstation/pull/76214/files
https://github.com/tgstation/tgstation/pull/70729/files
https://github.com/tgstation/tgstation/pull/77850/files
+ more, probably. I've marked the major ones.
Huge unit test that spawns almost every item in the game and then deletes it. This catches a lot of errors and harddels.
Why It's Good For The Game
More unit tests good.
Changelog
🆑
code: Ported tg's del the world unit test and brought our reference tracker and garbage collector mostly up to date. Also squashed a lot of harddels.
/:cl: