Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops the Weight Bench from being deleted when select wheel is closed #12967

Merged
merged 4 commits into from
May 17, 2023

Conversation

JackTheJackhammer
Copy link
Contributor

@JackTheJackhammer JackTheJackhammer commented May 13, 2023

About The Pull Request

Makes it so that the Weight Bench no longer gets banished to the shadowrealm if you dont wish to change the weights.

Why It's Good For The Game

The TGMC can now stop having to buy a new weight bench everytime someone changes their mind and banishes the Weight bench
Also fixes #12949

Changelog

🆑

fix: Weight Benches no longer disappear when unselecting the radial wheel.

/:cl:

@tgstation-server tgstation-server added the Fix Fixes an issue with the game. label May 13, 2023
Comment on lines +75 to +76
if(!choice)
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be before plates is set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait yeah you have a point

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackTheJackhammer it hasn't changed?

@Lumipharon
Copy link
Contributor

it didn't change my man.

@Lumipharon Lumipharon merged commit d7455e4 into tgstation:master May 17, 2023
github-actions bot added a commit that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fixes an issue with the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

you can delete the workout benchs
3 participants