Water alpha fixes #12924
Merged
Water alpha fixes #12924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
Sprites
|
this needs a speed merge so i can get my drip back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes #12881
Fixes a certain section of mob sprites being unclickable when in water.
Opacity has been set to 254 for the fully hidden section, which fixes this.
Fixes cape colours being broken due to keep_together.
Tweaks shield filter priority to 2. This gives this effect when in water.
Just a visual improvement. If someone knows how to make a new filter not cancel out the existing alpha mask filter when added, please let me know.
I cannot narrow down the actual cause of the clicking issue because the area that is impacted is the exact size of the full opaque part of the mask sprite, but has zero corrolation to WHERE it is on the sprite. May be a byond issue.
Why It's Good For The Game
Unclickable sprites bad
greyscale broken bad
Cool shield effect is cool
Changelog
🆑
fix: fixed mob sprites having unclickable areas when submerged in water
fix: fixed cape colours
/:cl: