Allow tables to be detected properly when inside of obsidian callouts #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not work and will need to be fixed in the upstream @tgrosinger/md-advance-tables repo.
|
Just realized as I was digging into it more that the tables do actually format properly. I had believed that they weren't because Obsidian doesn't use monospace font for tables when enclosed in a callout. That will need to be a fix at the obsidian level, which means this is actually functioning as intended. |
|
With monospaced font works great, would be nice to see as an optional in settings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply adds the
>to theleftMarginCharsby default. This allows md-advance-tables to detect tables inside of Obsidian callouts. Formatting of these kinds of tables is still broken and will need to be fixed in the upstream @tgrosinger/md-advance-tables repo.Tested in a vault with non-trivial (~50 files with callout-enclosed tables) usage and noticed no adverse affects.
Please advise if any additional work or testing is required, thanks for your consideration.