Avoid crashing upon invalid timestamps #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traceback (most recent call last):
File "rfc_stats.py", line 547, in <module>
for i, vote in enumerate(vote_page.get_votes()):
File "rfc_stats.py", line 303, in get_votes
yield Vote.from_line(self, line, section_label)
File "rfc_stats.py", line 89, in from_line
vote.datetime = cls.parse_datetime(line)
File "rfc_stats.py", line 125, in parse_datetime
return datetime.strptime(m.group(0), config.date_format)
File "/usr/lib64/python2.7/_strptime.py", line 325, in _strptime
(data_string, format))
ValueError: time data '24:14, 2 March 2014 (UTC)' does not match format '%H:%M, %d %B %Y (UTC)'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traceback (most recent call last):
File "rfc_stats.py", line 547, in
for i, vote in enumerate(vote_page.get_votes()):
File "rfc_stats.py", line 303, in get_votes
yield Vote.from_line(self, line, section_label)
File "rfc_stats.py", line 89, in from_line
vote.datetime = cls.parse_datetime(line)
File "rfc_stats.py", line 125, in parse_datetime
return datetime.strptime(m.group(0), config.date_format)
File "/usr/lib64/python2.7/_strptime.py", line 325, in _strptime
(data_string, format))
ValueError: time data '24:14, 2 March 2014 (UTC)' does not match format '%H:%M, %d %B %Y (UTC)'