-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Crystal code blocks #35
base: master
Are you sure you want to change the base?
Conversation
@infininight would you mind taking a look at this? 🙂 |
Looks good to me, @noniq will have to pull it in though as I'm not sure what he's doing with the integration here. |
Looks like I don't have the necessary permissions to override / fix the continuous integration checks in this bundle. Anyone else? |
@noniq Your the only one on the bundle other than me and Allan. I've stared at this permissions guide for 10 minutes and fail to see what permissions you need for that, doesn't seem to be listed? Edit: Oh it's a webhook, not an integration, that requires admin level access. Do you know what you want the settings to be there? Or should it be active, etc? |
I think this CI check was set up when @MikeMcQuaid was maintaining the repo. I don’t really have an idea how to make it work again, so I think we should just disable it for now. |
What it's doing is pretty simple: GitHub-Markdown.tmbundle/.travis.yml Lines 2 to 3 in 2b58b06
If desired/useful I can submit a PR to update to GitHub Actions. If not: no worries. |
So what did we decide here? @MikeMcQuaid do you want to take a stab at migrating to GitHub actions instead? 🙂 |
@kevinsjoberg Opened #36. Think @noniq will need to enable (or perhaps temporarily add me as a collaborator to setup and merge). @noniq While you're here if you can merge https://github.com/mikemcquaid/GitHub-Markdown-Font-Settings.tmbundle too that'd be handy! |
@MikeMcQuaid I don't have the permissions (as far as I see) to add new collaborators, but @infininight or @sorbits should be able to do it. |
@infininight do you have the proper permissions? 🙂 |
@sorbits do you have the proper permissions? 🙂 |
Add support for Crystal code blocks.