Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Crystal code blocks #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hovsater
Copy link

@hovsater hovsater commented Jul 12, 2021

Add support for Crystal code blocks.

Screenshot 2021-07-12 at 09 25 43

@hovsater
Copy link
Author

@infininight would you mind taking a look at this? 🙂

@infininight
Copy link
Member

Looks good to me, @noniq will have to pull it in though as I'm not sure what he's doing with the integration here.

@noniq
Copy link
Member

noniq commented Jul 18, 2021

Looks like I don't have the necessary permissions to override / fix the continuous integration checks in this bundle. Anyone else?

@infininight
Copy link
Member

infininight commented Jul 18, 2021

@noniq Your the only one on the bundle other than me and Allan. I've stared at this permissions guide for 10 minutes and fail to see what permissions you need for that, doesn't seem to be listed?

Edit: Oh it's a webhook, not an integration, that requires admin level access. Do you know what you want the settings to be there? Or should it be active, etc?

@noniq
Copy link
Member

noniq commented Jul 18, 2021

I think this CI check was set up when @MikeMcQuaid was maintaining the repo. I don’t really have an idea how to make it work again, so I think we should just disable it for now.

@MikeMcQuaid
Copy link
Contributor

What it's doing is pretty simple:

- xmllint --valid *.plist */*.tm* >/dev/null
- ruby -c */*/*.rb

If desired/useful I can submit a PR to update to GitHub Actions. If not: no worries.

@hovsater
Copy link
Author

hovsater commented Sep 9, 2021

So what did we decide here? @MikeMcQuaid do you want to take a stab at migrating to GitHub actions instead? 🙂

@MikeMcQuaid
Copy link
Contributor

@kevinsjoberg Opened #36. Think @noniq will need to enable (or perhaps temporarily add me as a collaborator to setup and merge).

@noniq While you're here if you can merge https://github.com/mikemcquaid/GitHub-Markdown-Font-Settings.tmbundle too that'd be handy!

@noniq
Copy link
Member

noniq commented Sep 14, 2021

@MikeMcQuaid I don't have the permissions (as far as I see) to add new collaborators, but @infininight or @sorbits should be able to do it.

@hovsater
Copy link
Author

@infininight do you have the proper permissions? 🙂

@hovsater
Copy link
Author

hovsater commented Apr 7, 2022

@sorbits do you have the proper permissions? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants