-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made links shorter by adding aliases #134
made links shorter by adding aliases #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested, but otherwise looks good to go
Hi @Burhan-Q thanks for the review. I made the changes suggested. |
new
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you want to add this to the repo. Also, now that it's here, you probably need to remove this key
new .pub
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also not be included
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove SSH files. Revoke SSH private key to prevent someone else from using it (guaranteed it's already compromised).
Sorry, removed the files now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove .vscode/settings.json since we're not using Antora. Otherwise, LGTM
@capsulecorplab Removed the settings.json file. |
Thanks @Venkat4real ! Though it looks like you closed the PR without merging. Would you mind re-opening? |
Hi Sean @capsulecorplab . I reopened the PR |
for the issue #131