-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP #1249
base: dev
Are you sure you want to change the base?
WIP #1249
Conversation
db30401
to
8c8a383
Compare
|
||
""" | ||
TODO | ||
GarageDoor Cyclic: Ask to https://github.com/iMicknl/ha-tahoma/issues/146 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just add it like this:
CyclicGarageDoor
OverkizCoverDescription(
key=UIWidget.CYCLIC_GARAGE_DOOR,
open_command=OverkizCommand.CYCLE,
close_command=OverkizCommand.CYCLE,
stop_command=OverkizCommand.STOP,
device_class=CoverDeviceClass.GARAGE,
),
set_position_command=OverkizCommand.SET_DEPLOYMENT, | ||
open_command=OverkizCommand.DEPLOY, | ||
close_command=OverkizCommand.UNDEPLOY, | ||
invert_position=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should not be necessary?
|
||
|
||
COVER_DESCRIPTIONS: list[OverkizCoverDescription] = [ | ||
OverkizCoverDescription( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to set supported_features as well, otherwise this won't work like it did before.
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: