Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check wrapper element to fix #311 #312

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Conversation

hcg1023
Copy link
Contributor

@hcg1023 hcg1023 commented Feb 28, 2024

fix #311

@afontcu
Copy link
Member

afontcu commented Mar 7, 2024

hey! thank you for this :) it would be great if you could add a small test to assert that the bug is fixed – and to make sure it doesn't pop up again in the future.

thank you!

@hcg1023
Copy link
Contributor Author

hcg1023 commented Mar 7, 2024

@afontcu I added test case

Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Added a few comments, almost there!

src/__tests__/render.js Outdated Show resolved Hide resolved
src/render.js Outdated Show resolved Hide resolved
src/__tests__/render.js Outdated Show resolved Hide resolved
@afontcu afontcu merged commit 3ecde9e into testing-library:main Mar 18, 2024
4 checks passed
Copy link

🎉 This PR is included in version 8.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after manually calling the umount method, cleanupAtWrapper will report an error
2 participants