Repository navigation
Support directory uploads without multiple - #1338
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
Contributor
Please run this and report back |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow
uploadto retain all files when a file input selects a directory viawebkitdirectory, even ifmultipleis absent. Fixes #1292.Why
A single selected directory can contain multiple files. Previously the upload helper truncated that selection to the first file.
How
Treat a directory input as a multi-file selection; keep the existing single-file limit for ordinary inputs. Check both the property and the attribute because jsdom may not reflect the non-standard property.
Checklist
AI assistance: Codex assisted with the implementation and tests.
Browser verification
In Brave on Windows, we manually selected a directory using the native picker on an input with
webkitdirectoryand withoutmultiple. The browser returned five files. Passing those files touserEvent.uploadon a second input with the same attributes retained all five, with matching file names andwebkitRelativePathvalues. The selected directory had no nested folders.