feat: add option to set element class on hover#1212
Open
rChaoz wants to merge 2 commits intotesting-library:mainfrom
Open
feat: add option to set element class on hover#1212rChaoz wants to merge 2 commits intotesting-library:mainfrom
rChaoz wants to merge 2 commits intotesting-library:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important: I have two different changes in the same PR as I want to use the version generated by codesandbox, but when ready to mege this can be fixed.
What:
.my-hover-classon top of:hoverin CSS or with a plugin such as the one for PostCSS or Storybook.startSelecting()is called beforefocusElement(). Setting a selection on an element sets that element as thedocument.activeElement, causingfocusElement()not to do anything.Why:
Allow testing of CSS hover states using
userEvent.hover/userEvent.unhoveror other commands that move the mouse.How:
Add a new config option
hoverClass(string) which defaults to null. When set (non-null),target.classList.add(hoverClass)is called whenevermouseenteris emitted andtarget.classList.remove(hoverClass)whenevermouseleaveis emitted.Checklist: