Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): upgrade Jest v28 to v29 #857

Closed
wants to merge 2 commits into from
Closed

build(deps-dev): upgrade Jest v28 to v29 #857

wants to merge 2 commits into from

Conversation

lesha1201
Copy link
Contributor

@lesha1201 lesha1201 commented Dec 12, 2023 •
edited
Loading

@Belco90 Belco90 self-requested a review December 13, 2023 12:31
@Belco90 Belco90 added the dependencies Pull requests that update a dependency file label Dec 13, 2023
Belco90
Belco90 previously approved these changes Dec 13, 2023
View reviewed changes
@lesha1201
Copy link
Contributor Author

lesha1201 commented Dec 14, 2023 •
edited
Loading

@Belco90 CI for Node.js v12 is failing because Jest v29 dropped support of it. I'm not sure why linter is failing, I will investigate it (UPD: it were failing because of missing @types/prettier, previously it were installed by some dependency).

Should we close this PR or remove CI for Node v12?

@lesha1201 lesha1201 mentioned this pull request Dec 14, 2023
Merged
1 task
@Belco90
Copy link
Member

Belco90 commented Jan 12, 2024

Let's close this PR for now, we will update jest when upgrading node.

@Belco90 Belco90 closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 left review comments

Assignees

@lesha1201 lesha1201

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lesha1201 @Belco90