Adds ability to supply template files to catalog request #57
Conversation
* dump a single template or all templates using class methods
* moves test from request to client_spec where it should be
* previously if you wanted to create a request from a old request
you had to carefully merge the values from a json payload into
parameters. This makes it dead simple by allowing the user
to create a request from a previously saved request template
file.
|
Travis isn't responding correctly despite passing tests. |
|
@jjasghar have you had a chance to look at this? |
|
I just got my vRA instance up last week. I'll be revisiting this ASAP. |
|
For reference real world usage is documented here: https://github.com/nwops/kitchen-vmpool#vmware-vra-pool-creation-scripts Scripts Although the code is very specific to my use case and contains a few monkey patches. |
|
Hi all, |
|
@okleinschmidt can you verify the destroy method works with 7.3? I think I found a bug with it, downstream with chef/knife-vrealize#33 but it resonates in this gem. As you can see from the second comment they moved the |
|
@jjasghar for me destroy works as well. I've verified with my own code which uses vmware-vra gem as well as with knife-vrealize (see below). The chef server error happens because there is no chef at the moment. `knife vra server delete aaad0736-ad95-4aa9-a1ac-55722cf091d6 Do you really want to delete this server? (Y/N) y Request Status: SUCCESSFUL WARNING: Corresponding node and client for the XXXX server were not deleted and remain registered with the Chef Server |
|
Oh wow, it must be my environment then. Thanks! I'll work on it asap, and then get this merged and released. |
Description
Adds ability to supply custom request templates from file. If you have a bunch of
saved catalog templates you can now just create catalog requests from those templates
or even just merge in those templates with your current catalog request object.
Why is this important? Test-kitchen automates this process for you. But if you are not using this for some other project, you will eventually want to have this feature since trying to merge properties via set_parameter is very painful. As noted in #54
This MR also supersedes #56 since it was required to make this feature. Merging this request negates the need to merge #56
This MR also fixes some tests that were skipped in the catalog_request specs.
For an example catalog template, please see
spec/fixtures/catalog_request_template.jsonIssues Resolved
N|A
Check List