Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use " HTML entity for mermaid double quotes #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use " HTML entity for mermaid double quotes #59

wants to merge 1 commit into from

Conversation

belak
Copy link

@belak belak commented Sep 22, 2024

I couldn't get all the dependencies needed for rendering everything locally, but this seems to be the only way to support double quotes in label names with Mermaid.

You can see this working on the mermaid playground.

alixander
alixander approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

alixander
alixander reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mermaid's CLI fails rendering this for some reason. Probably doesn't like the unsafe injection? idk their error is vague. I'll revisit this from time to time to see if it's fixed

Screenshot 2024-09-23 at 7 57 17 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belak @alixander