Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatter: ignore shebang comments #1471

Closed
wants to merge 2 commits into from
Closed

formatter: ignore shebang comments #1471

wants to merge 2 commits into from

Conversation

berniexie
Copy link
Contributor

Closes #1319
Shebang criteria is line number 0 and comment starts with "#!"

@berniexie berniexie requested a review from alixander July 7, 2023 20:49
@berniexie berniexie marked this pull request as ready for review July 7, 2023 20:49
alixander
alixander requested changes Jul 10, 2023
View reviewed changes
d2format/format_test.go Show resolved Hide resolved
@berniexie berniexie requested a review from alixander July 20, 2023 17:45
@alixander
Copy link
Collaborator

now that #410 is closed, the use case for this is no longer needed

@alixander alixander closed this Jul 22, 2023
@alixander alixander mentioned this pull request Jul 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander Awaiting requested review from alixander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: 'd2 fmt' adds spaces after every comment # , breaking shebang header lines
2 participants
@berniexie @alixander