position tooltip/link icons on shape #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavin-ts
changed the title
alixander
requested changes
Jul 4, 2023
There was a problem hiding this comment.
- the position for package particularly is weird. the algorithm should be changed to be "top right corner" for package, hexagon, and step shapes.
- i think having the "both" icons be on two different axes to be very weird. we should find the placement for one, and then place the other one to the right of it. even if it floats, there's no ambiguity.
updated (again):
|
alixander
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update renderer to position tooltip/link icons on the shape's border.
Details
before/after