Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate several pages into Korean #202

Merged
merged 15 commits into from
May 2, 2024
Merged

Conversation

Baejw0111
Copy link
Contributor

Long time no see! Sorry for the lack of updates for a long time. There was a program I was participating in that ended and I took a bit of a long break. I'll see you again often!

Copy link
Contributor

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baejw0111 thank you for this, truly appreciate it 🙏

I made a rather big refactor recently that links all the D2 code snippets to be all from one place instead of repeating it.

https://github.com/terrastruct/d2-docs/pull/203/files#diff-6c691c53270128394a5d4fee3d772141779a0dc3acb83acc49d0954241a6ab6eR1

Would it be possible to include that refactor here too? That way when any code changes, it changes for both the english and korean versions without having to update multiple places.

@Baejw0111
Copy link
Contributor Author

Oh, I see. When I work on translation, only the English part will be changed to Korean, so the code with refactoring will be included in the translation. I will add the documents that have already been translated separately.

@Baejw0111
Copy link
Contributor Author

Baejw0111 commented Apr 13, 2024

@alixander Please review

Copy link
Contributor

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much 👍 , and sorry for the delay. I think the Korean version is almost there as the first translation of D2's documentation!

I'm not sure why when I render in Korean, there's two missing assets in the home page.

Screenshot 2024-05-02 at 3 45 34 PM

Probably not related to this PR though, so not blocking, just noting.

@alixander alixander merged commit e9732b8 into terrastruct:master May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants