Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt.sh: Render all d2 diagrams automatically #22

Merged
merged 2 commits into from
Jan 24, 2023
Merged

fmt.sh: Render all d2 diagrams automatically #22

merged 2 commits into from
Jan 24, 2023

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Dec 8, 2022

Closes #1

@nhooyr nhooyr requested a review from alixander December 8, 2022 12:18
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 8, 2022

Maybe we should have a separate gen.sh? This doesn't really seem like something that belongs in fmt. go mod tidy and package.json too are more gen. likewise with mdtocsubst

@nhooyr nhooyr mentioned this pull request Dec 8, 2022
Open
alixander
alixander reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does it gen to?

@nhooyr nhooyr mentioned this pull request Dec 12, 2022
Closed
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 12, 2022

where does it gen to?

The default, just the same file name but as .svg

@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 24, 2023

Oh noo, I should actually make this instead just d2 fmt for now.

@nhooyr nhooyr requested a review from alixander January 24, 2023 22:07
@nhooyr nhooyr merged commit 1c94f3d into master Jan 24, 2023
@nhooyr nhooyr deleted the d2-b060 branch January 24, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for checking that all D2 renders are up to date
2 participants
@nhooyr @alixander