updated method name to match records in BETYdb #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlebauer
added a commit
to AgPipeline/transformer-canopycover
that referenced
this pull request
Mar 7, 2020
Same as terraref/extractors-stereo-rgb#56; to match method name in BETYdb
Chris-Schnaufer
approved these changes
Mar 10, 2020
Chris-Schnaufer
pushed a commit
to AgPipeline/transformer-canopycover
that referenced
this pull request
Apr 1, 2020
Same as terraref/extractors-stereo-rgb#56; to match method name in BETYdb
Chris-Schnaufer
added a commit
to AgPipeline/transformer-canopycover
that referenced
this pull request
Apr 1, 2020
* Fixing up README and type declarations (#1) * Minor cleanup * Updated file docstring * Updating README * Fixing up return type * Ignore .idea folders, put old README contents into new README, reconciled return types * Updated README moved algorithm description to the top, instructions for use below. * update method name (#5) Same as terraref/extractors-stereo-rgb#56; to match method name in BETYdb * Merge update with develop * Made change based on Zongyang's feedback * Changes based upon feedback * minor formatting changes Co-authored-by: Chris Schnaufer <[email protected]>
Chris-Schnaufer
added a commit
to AgPipeline/transformer-canopycover
that referenced
this pull request
May 6, 2020
* Fixing up README and type declarations (#1) * Minor cleanup * Updated file docstring * Updating README * Fixing up return type * Ignore .idea folders, put old README contents into new README, reconciled return types * update method name (#5) Same as terraref/extractors-stereo-rgb#56; to match method name in BETYdb * Moved most content to soilmask-transformer The soilmask transformer has been separated into 1) generate soilmask in https://github.com/AgPipeline/transformer-soilmask/ and 2) compute area of soilmask that is plant (this repository). Updating both readmes to reflect this. TODO: Check that this is consistent with existing code and examples (this repo should start with a mask and return a canopy cover, or else have the soilmask as a dependency and take in an RGB image and return a mask + canopy cover). See also AgPipeline/transformer-soilmask#11 * Update README.md Co-Authored-By: Chris Schnaufer <[email protected]> * moved figures to transformer-soilmask repository * Pushing transformer.py * tried to update algorithm for pylint preferences; might still be some errors because indentation did not seem to be preserved and wasn't present on the repo * Changed the masked canopy cover calculation in transformer.py * updated canopy cover algorithm and ran pylint * made changes * made changes and ran pylint * changed file to reflect pull request * Update README.md * Update README.md * Fixed algorithm (#9) Co-authored-by: David LeBauer <[email protected]> Co-authored-by: David LeBauer <[email protected]> Co-authored-by: Jacob van der Leeuw <[email protected]> Co-authored-by: jvanderleeuw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method Name in BETYdb is "Green Canopy Cover Estimation from Field Scanner RGB images"
Per terraref/reference-data#283 (comment)