Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing reactor param powerDecay #1797

Closed
wants to merge 1 commit into from
Closed

Removing reactor param powerDecay #1797

wants to merge 1 commit into from

Conversation

john-science
Copy link
Member

What is the change?

Removing reactor param powerDecay

Why is the change being made?

To close #1793

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Jul 24, 2024
@john-science
Copy link
Member Author

@wcscherer FYI!

opotowsky
opotowsky approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off and merge this one last. See me offline for why!

@john-science
Copy link
Member Author

@opotowsky Don't merge this one yet. I am going to do some more downstream testing. #paranoia

@john-science
Copy link
Member Author

After some research, I determined this parameter is used downstream. So I am just going to close this.

@john-science john-science deleted the rm_r_power_decay branch July 24, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ARMI param core.p.powerDecay Unused
2 participants
@john-science @opotowsky