Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up a minor bug in #1653 #1751

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Clean up a minor bug in #1653 #1751

merged 6 commits into from
Jun 27, 2024

Conversation

mgjarrett
Copy link
Contributor

@mgjarrett mgjarrett commented Jun 26, 2024

What is the change?

Change logic in CrossSectionGroupManager to handle the case where BlockCollection._validRepresentativeBlockTypes is None.

Why is the change being made?

This logic was introduced in PR #1653. The logic checks for the length of _validRepresentativeBlockTypes, assuming it is always a list. It did not consider the case where _validRepresentativeBlockTypes is None.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@mgjarrett mgjarrett added the bug Something is wrong: Highest Priority label Jun 26, 2024
@mgjarrett
Copy link
Contributor Author

@john-science this PR addresses a corner case bug in PR #1653 that wasn't caught until after it was merged.

@mgjarrett mgjarrett marked this pull request as ready for review June 26, 2024 20:05
Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have the one comment. Tell me what you think.

@john-science john-science merged commit 9d6e2b0 into main Jun 27, 2024
14 checks passed
@john-science john-science deleted the fix_1653_bug branch June 27, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants