Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up build tools #1723

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Cleaning up build tools #1723

merged 7 commits into from
Jun 5, 2024

Conversation

john-science
Copy link
Member

@john-science john-science commented Jun 4, 2024

What is the change?

Here I clean up our build tools in twoways:

  1. Splitting our unit test Worflows into two parts:
  • Older versions of Python get Ubuntu 22.04
  • Newer versions of Python need Ubuntu 24.04
  1. Dropping direct usage of distutils

Why is the change being made?

With this PR I was originally trying to support Python 3.12 but found that we couldn't due to our NumPy jagged array issue.

But this PR gets ARMI 99.9% ready for Python 3.12; everything except our NumPy woes.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the ci Related to continuous integration / github actions label Jun 4, 2024
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice dep cleanup!

Do we even NEED py37/38 testing still?

I leave that up to you. I approve 🎉

@john-science
Copy link
Member Author

Do we even NEED py37/38 testing still?

I don't know. That is certainly pretty borderline.

I assume support for those will drop naturally in the next year or two. Like, it'll be too hard to support 3.7 AND 3.12 for numpy or something, and we'll just drop support for numpy. Like, the moment it becomes hard to support them, we'll drop support.

But, for now, it's still easy. #shrug

@john-science john-science merged commit f9903fe into main Jun 5, 2024
23 checks passed
@john-science john-science deleted the py13_tests branch June 5, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration / github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants