Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial fixes for various rxcoeff params #1522

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Editorial fixes for various rxcoeff params #1522

merged 4 commits into from
Dec 19, 2023

Conversation

keckler
Copy link
Member

@keckler keckler commented Dec 6, 2023

What is the change?

This is a continuation of #1498. I wish I had caught everything in that single PR, but alas I did not.

I only do the following:

  • change the units strings on a handful of parameters in which there was a stray parenthesis at the end
  • Make the capitalization and punctuation consistent across rxcoeff param descriptions (didn't change the param names themselves)

No physics changes at all.

Why is the change being made?

Cleanliness.


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • No requirements were altered.
  • The dependencies are still up-to-date in pyproject.toml.

@keckler keckler marked this pull request as draft December 6, 2023 22:54
@keckler
Copy link
Member Author

keckler commented Dec 6, 2023

Give me a second to also update the parameter descriptions to have reasonable formatting.

@keckler keckler changed the title Remove stray closing parenthesis from various rxcoeff params Editorial fixes for various rxcoeff params Dec 6, 2023
@keckler
Copy link
Member Author

keckler commented Dec 6, 2023

Okay, this is ready to go now. I also made the capitalization and ending punctuation consistent between all the rxcoeffs param descriptions.

@keckler keckler marked this pull request as ready for review December 6, 2023 23:04
@keckler
Copy link
Member Author

keckler commented Dec 11, 2023

Fix the one parameter that has "dk/k/k" instead of "\Deltak/k/k"

EDIT: Done.

@john-science john-science added the enhancement New feature or request label Dec 19, 2023
@keckler keckler merged commit 86f55a6 into main Dec 19, 2023
23 checks passed
@keckler keckler deleted the unitsRound2 branch December 19, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants