Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: existing scc instance support #138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: existing scc instance support #138

wants to merge 2 commits into from

Conversation

Soaib024
Copy link
Member

@Soaib024 Soaib024 commented Jul 1, 2024

Description

#140

Support for existing scc instance

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Soaib024
Copy link
Member Author

Soaib024 commented Jul 1, 2024

/run pipeline

@Soaib024
Copy link
Member Author

Soaib024 commented Jul 1, 2024

/run pipeline

@Soaib024 Soaib024 self-assigned this Jul 2, 2024
@Soaib024 Soaib024 marked this pull request as ready for review July 2, 2024 07:40
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would of thought this support should be added directly into https://github.com/terraform-ibm-modules/terraform-ibm-scc (and then exposed in the DA). That way we can support auth policy creation and attaching of an SCC Workload Protection instance to an existing SCC instance.

Also you need to ensure outputs support existing instance. For example you seem to be defaulting the value of the scc_crn to null when passing existing instance, when actually you should output the CRN of the existing instance.

@Soaib024
Copy link
Member Author

Soaib024 commented Jul 3, 2024

Created a PR to support existing scc instance in module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants