Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test to run in schematics workspace and update ibm_catalog.json #256

Closed
wants to merge 13 commits into from
Closed

Update test to run in schematics workspace and update ibm_catalog.json #256

wants to merge 13 commits into from

Conversation

iamar7
Copy link
Member

@iamar7 iamar7 commented Dec 31, 2024 •
edited
Loading

Description

Review and adjust catalog types for the DA.

Release required?

Resolves: #235

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7 iamar7 self-assigned this Jan 1, 2025
@iamar7 iamar7 marked this pull request as draft January 9, 2025 03:44
@iamar7
Copy link
Member Author

iamar7 commented Jan 9, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Jan 9, 2025

/run pipeline

@iamar7 iamar7 changed the title Update ibm_catalog.json Update test to run in schematics workspace and update ibm_catalog.json Jan 9, 2025
@iamar7
Copy link
Member Author

iamar7 commented Jan 9, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Jan 16, 2025

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented Jan 17, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Jan 17, 2025

/run pipeline

@iamar7 iamar7 closed this Jan 22, 2025
@iamar7
Copy link
Member Author

iamar7 commented Jan 22, 2025

Will be creating a new PR for updating test to run in schematics workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankellyibm brendankellyibm Awaiting requested review from brendankellyibm brendankellyibm is a code owner

Assignees

@iamar7 iamar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update test to run in schematics and use private provider visability
2 participants
@iamar7 @Ak-sky