chore: Migrate kitchen -> cft #429
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvans
commented
Oct 14, 2025
| // Note: DefaultVerify() is unusable here because some attributes, | ||
| // such as last_modified_time, are changed outside of Terraform's knowledge. | ||
|
|
||
| projectID := dwh.GetTFSetupStringOutput("project_id") |
There was a problem hiding this comment.
This stuff is a relatively straightforward copy of big_query.rb, with some minor differences about how values are represented (such as "nil" in big_query.rb vs an empty list in the terraform output and therefore this go file).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Status:
Similarly to GoogleCloudPlatform/terraform-google-cloud-run#404, this PR gets rid of kitchen in this repo to unblock multi-project test setup.
TestDataWarehouse is hitting " Workflows service agent does not exist" error. But the CI history shows several of that error (and various others) in TestDataWarehouse, even without this PR:
So I think this PR is not making things worse.