Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(TPG>=5.39)!: add resource_tags #354

Merged
merged 13 commits into from
Oct 16, 2024

Conversation

lord-skinner
Copy link
Contributor

No description provided.

Copy link

google-cla bot commented Sep 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lord-skinner lord-skinner changed the title adding resource_tags feature: resource_tags Sep 11, 2024
@lord-skinner
Copy link
Contributor Author

Closes #351

@lord-skinner
Copy link
Contributor Author

@davenportjw @shanecglass The CI error failing is Needs /gcbrun from a collaborator, but I'm not sure how to proceed with this information.

Can you let us know how to proceed?

cc:@rohilla-anuj

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you also bump the min provider version 1 to > 5.39. Looks like thats when this field was added per https://github.com/hashicorp/terraform-provider-google/blob/main/CHANGELOG.md#5390-july-29th-2024

@bharathkkb
Copy link
Member

/gcbrun

@rohilla-anuj
Copy link
Contributor

@bharathkkb Thanks for looking into the PR.
Made the change as per your suggestion.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few lint errors are reported

  • Run 'make docker_generate_docs' command and commit the generated readme update.
  • Checking for trailing whitespace ./README.md:39

@rohilla-anuj
Copy link
Contributor

Fixed the Lint error.
@bharathkkb can you approve /gcbrun again.

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

versions.tf Outdated Show resolved Hide resolved
@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

Thanks @lord-skinner - Can you please rebase this change (its not enabled for maintainers), otherwise it LGTM.

@apeabody apeabody changed the title feature: resource_tags feature(TPG>=5.39)!: add resource_tags Oct 16, 2024
@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

Thanks @lord-skinner - Can you please rebase this change (its not enabled for maintainers), otherwise it LGTM.

Thanks for the contribution @lord-skinner!

@apeabody apeabody merged commit c07d42e into terraform-google-modules:master Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants