-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(TPG>=5.39)!: add resource_tags #354
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Closes #351 |
@davenportjw @shanecglass The CI error failing is Can you let us know how to proceed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you also bump the min provider version 1 to > 5.39. Looks like thats when this field was added per https://github.com/hashicorp/terraform-provider-google/blob/main/CHANGELOG.md#5390-july-29th-2024
/gcbrun |
Upgrade the package version constraint.
@bharathkkb Thanks for looking into the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few lint errors are reported
- Run 'make docker_generate_docs' command and commit the generated readme update.
- Checking for trailing whitespace ./README.md:39
Fixed the Lint error. |
/gcbrun |
/gcbrun |
/gcbrun |
Thanks @lord-skinner - Can you please rebase this change (its not enabled for maintainers), otherwise it LGTM. |
/gcbrun |
Thanks for the contribution @lord-skinner! |
No description provided.