Skip to content

docs: Custom SAN examples #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pandirigoog
Copy link

@pandirigoog pandirigoog commented Apr 30, 2025

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@pandirigoog pandirigoog requested review from a team as code owners April 30, 2025 23:32
Copy link

snippet-bot bot commented Apr 30, 2025

Here is the summary of changes.

You are about to add 18 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@pandirigoog pandirigoog changed the title Custom SAN examples docs: Custom SAN examples Apr 30, 2025
* See the License for the specific language governing permissions and
* limitations under the License.
*/
# [START cloud_sql_instance_service_identity]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Region tags need to be unique.

sugg: Try the following format

cloud_sql_<db-type>_instance_service_identity

db-type can be mysql or postgres or sqlserver

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example:

Instead of cloud_sql_instance_service_identity use cloud_sql_mysql_instance_service_identity

Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR has a great start! Need minor changes to improve.

  1. Try to keep region tags unique
  2. Add descriptions or comments to understand why a resources is created. This optional for your but very helpful for me & users to understand your motivation.

Example: description = "Create example sql instance with CA ..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants