-
Notifications
You must be signed in to change notification settings - Fork 250
docs: Custom SAN examples #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cloud_sql/mysql_instance_custom_subject_alternative_names/main.tf
Outdated
Show resolved
Hide resolved
cloud_sql/mysql_instance_custom_subject_alternative_names/main.tf
Outdated
Show resolved
Hide resolved
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
# [START cloud_sql_instance_service_identity] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Region tags need to be unique.
sugg: Try the following format
cloud_sql_<db-type>_instance_service_identity
db-type can be mysql
or postgres
or sqlserver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example:
Instead of cloud_sql_instance_service_identity
use cloud_sql_mysql_instance_service_identity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR has a great start! Need minor changes to improve.
- Try to keep region tags unique
- Add descriptions or comments to understand why a resources is created. This optional for your but very helpful for me & users to understand your motivation.
Example: description = "Create example sql instance with CA ..."
Description
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review