Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Conditionally enable public and private subnet tags #1146

Conversation

kaykhan
Copy link

@kaykhan kaykhan commented Nov 29, 2024

Description

Introduces 2 new variables enable_private_subnet_tags and enable_public_subnet_tags.

Motivation and Context

#1145

Breaking Changes

These new variable are set to true by default so i assume it would not introduce any breaking change

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@kaykhan kaykhan changed the title feat: conditionally enable public and private subnet tags Feat: conditionally enable public and private subnet tags Nov 29, 2024
@kaykhan kaykhan changed the title Feat: conditionally enable public and private subnet tags feat: Conditionally enable public and private subnet tags Nov 29, 2024
@kaykhan
Copy link
Author

kaykhan commented Nov 29, 2024

:(

╷
│ Error: Unsupported block type
│ 
│   on ../../main.tf line 114, in resource "aws_subnet" "public":
│  114:   dynamic "tags" {
│ 
│ Blocks of type "tags" are not expected here.
╵
╷
│ Error: Unsupported block type
│ 
│   on ../../main.tf line 255, in resource "aws_subnet" "private":
│  255:   dynamic "tags" {
│ 
│ Blocks of type "tags" are not expected here.
╵

@kaykhan kaykhan closed this Nov 29, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant