feat: Added additional conditions into Flow Log IAM Role Assumption Policy #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschykowski
changed the title
antonbabenko
changed the title
antonbabenko
approved these changes
Nov 18, 2024
antonbabenko
merged commit 7744d3f
into
terraform-aws-modules:master
19 of 20 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Nov 18, 2024
## [5.16.0](v5.15.0...v5.16.0) (2024-11-18) ### Features * Added additional conditions into Flow Log IAM Role Assumption Policy ([#1138](#1138)) ([7744d3f](7744d3f))
|
This PR is included in version 5.16.0 🎉 |
2 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows modifications to the assume role policy of the flow log IAM role.
Motivation and Context
The recommended action by AWS to prevent confused deputy attacks is to add sourceArn, sourceAccount or sourceOrg as conditions as condition to the role assumption. https://docs.aws.amazon.com/IAM/latest/UserGuide/confused-deputy.html
Breaking Changes
Should not break anything, as the default variable is empty and will simply not render the dynamic block.
How Has This Been Tested?
pre-commit run -aon my pull request