Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NAT gw route table associations shouldn't be created when enable_nat_gateway=false #1090

Closed
wants to merge 2 commits into from
Closed

fix: NAT gw route table associations shouldn't be created when enable_nat_gateway=false #1090

wants to merge 2 commits into from

Conversation

kkonstant-in
Copy link

@kkonstant-in kkonstant-in commented Jun 5, 2024 •
edited
Loading

Description

Fixes creating NAT gateway route table associations even when enable_nat_gateway=false

Motivation and Context

More detailed description of the issue is here #1031

Breaking Changes

no breaking changes

How Has This Been Tested?

Tested in production TGW environment with no NAT gw route table associations

@kkonstant-in kkonstant-in changed the title Fix creating nat gw aws_route_table_association's when enable_nat_gateway=false fix: creating nat gw aws_route_table_association's when enable_nat_gateway=false Jun 5, 2024
@kkonstant-in kkonstant-in changed the title fix: creating nat gw aws_route_table_association's when enable_nat_gateway=false fix: NAT gw route table associations shouldn't be created when enable_nat_gateway=false Jun 5, 2024
@bryantbiggs bryantbiggs mentioned this pull request Jun 10, 2024
Open
3 tasks
@kkonstant-in
Copy link
Author

Hi there.

@bryantbiggs do you need a more detailed description or anything else for this issue?
Looks like a simple fix, isn't it?

@kkonstant-in
Copy link
Author

Hi, any updates?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 8, 2024
@kkonstant-in
Copy link
Author

Hi, any updates?

@github-actions github-actions bot removed the stale label Aug 9, 2024
@kkonstant-in
Copy link
Author

Hi, any updates?

1 similar comment
@kkonstant-in
Copy link
Author

Hi, any updates?

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 19, 2024
@kkonstant-in
Copy link
Author

Hi, any updates?

@github-actions github-actions bot removed the stale label Oct 20, 2024
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 20, 2024
@kkonstant-in
Copy link
Author

Hi, any updates?

@kkonstant-in kkonstant-in closed this by deleting the head repository Nov 20, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kkonstant-in