feat: Add elb_log_delivery_policy_source_organizations variable
#330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szubersk
force-pushed
the
szubersk-flow-logs
branch
from
e411b02 to
adb163d
Compare
* New `elb_log_delivery_policy_source_organizations` variable allows scoping access to the S3 bucket to AWS organization. * Improve security by scoping ALB/NLB/VPC flow logs access to the caller's AWS account. * Improve variable description. According to AWS documentation, the same S3 permissions can be used for both NLB access logs and VPC flow logs. References: * https://docs.aws.amazon.com/vpc/latest/userguide/flow-logs-s3-permissions.html * https://docs.aws.amazon.com/elasticloadbalancing/latest/network/enable-access-logs.html * https://docs.aws.amazon.com/elasticloadbalancing/latest/application/enable-access-logging.html Fix terraform-aws-modules#324 Signed-off-by: szubersk <[email protected]>
szubersk
force-pushed
the
szubersk-flow-logs
branch
from
adb163d to
4570fd3
Compare
bryantbiggs
reviewed
Jun 18, 2025
| @@ -622,7 +622,7 @@ data "aws_iam_policy_document" "elb_log_delivery" { | |||
| for_each = { for k, v in local.elb_service_accounts : k => v if k == data.aws_region.current.name } | |||
|
|
|||
| content { | |||
| sid = format("ELBRegion%s", title(statement.key)) | |||
There was a problem hiding this comment.
this is a breaking change and should not be modified at this time
bryantbiggs
reviewed
Jun 18, 2025
| @@ -5,13 +5,13 @@ variable "create_bucket" { | |||
| } | |||
|
|
|||
| variable "attach_elb_log_delivery_policy" { | |||
| description = "Controls if S3 bucket should have ELB log delivery policy attached" | |||
There was a problem hiding this comment.
why are there all of these changes? ELB is correct - ALB and NLB are in fact ELB v2 (classic load balancer was ELB v1)
bryantbiggs
requested changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New
elb_log_delivery_policy_source_organizationsvariable allows scoping access to the S3 bucket to AWS organization.Improve security by scoping ALB/NLB/VPC flow logs access to the caller's AWS account.
Improve variable description. According to AWS documentation, the same S3 permissions can be used for both NLB access logs and VPC flow logs.
References:
https://docs.aws.amazon.com/vpc/latest/userguide/flow-logs-s3-permissions.html
https://docs.aws.amazon.com/elasticloadbalancing/latest/network/enable-access-logs.html
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/enable-access-logging.html
Motivation and Context
Fix #324
Breaking Changes
N/A
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request