Skip to content

fix: Add aws_partition to support usage of this module in aws-cn and gov #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vladislav-orlovskiy
Copy link
Contributor

@vladislav-orlovskiy vladislav-orlovskiy commented Apr 4, 2025

Description

add data source aws_partition

replace hardcoded partition aws with ${data.aws_partition.current.partition}

Motivation and Context

This changes is needed so module could correctly work in china and gov regions.

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Sorry, something went wrong.

@vladislav-orlovskiy
Copy link
Contributor Author

not sure why Pre-commit / Max TF pre-commit check is failing
pre-commit run --all-files locally are completed successfully

Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
mixed line ending........................................................Passed

@vladislav-orlovskiy
Copy link
Contributor Author

@antonbabenko would you mind take a look at that?

@antonbabenko antonbabenko merged commit 7305b74 into terraform-aws-modules:master Apr 9, 2025
30 checks passed
@antonbabenko
Copy link
Member

This PR is included in version 7.20.2 🎉

Copy link

github-actions bot commented May 9, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants