Skip to content

fix: Use local log_group throughout, fixing log configuration with Lambda@Edge. #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

theherk
Copy link

@theherk theherk commented Mar 13, 2025

Fixes #650 and #665.

Description

Motivation and Context

This allows module implementations using lambda_at_edge = true to actually log to Cloudwatch.

Breaking Changes

This will cause changes for users using lambda_at_edge = true, but is is a fixing change.

How Has This Been Tested?

  • I have verified the changes in my infrastructure.
  • I have executed pre-commit run -a on my pull request
  terraform-aws-lambda
ᐅ pre-commit run -a
Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
mixed line ending........................................................Passed

@theherk theherk changed the title Use local log_group throughout, fixing log configuration with Lambda@Edge. fix: Use local log_group throughout, fixing log configuration with Lambda@Edge. Mar 13, 2025
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 13, 2025
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Apr 24, 2025
@theherk
Copy link
Author

theherk commented Apr 24, 2025

Cool, another PR closed out of hand because these repositories are mostly unmonitored. 👍

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudwatch log group for Lambda@Edge is not set correctly
1 participant