chore: Use appropriate mapping of assume_role_policy #570
+15
−105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
https://aws.amazon.com/blogs/security/announcing-an-update-to-iam-role-trust-policy-behavior/
we need to allow the role to assume itself.
Current configuration was set to
AWS: "*"
with a conditional.This is detected as a bad policy by AWS, where it flags the trust policy
Additionally this "Self Assume" causes IAM looping which can lead to multiple requests, increase cloudtrail audit logs, etc
Motivation and Context
This saves security teams from seeing
AWS: "*"
and panickingBreaking Changes
No
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request