Skip to content

feat: Add support for update_policy #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

gallois
Copy link
Contributor

@gallois gallois commented Oct 2, 2024

Description

Add update_policy to compute_environment

Motivation and Context

Feature is missing

@bryantbiggs
Copy link
Member

what version was this added within

@gallois
Copy link
Contributor Author

gallois commented Oct 11, 2024

Added on top of 4f83e65, right after 2.1.0

@bryantbiggs
Copy link
Member

no no - what version of the AWS provider was this argument added

@gallois
Copy link
Contributor Author

gallois commented Oct 11, 2024

looks like this one 5.32.0?

@bryantbiggs
Copy link
Member

then this is a breaking change

version = ">= 4.0"

@gallois
Copy link
Contributor Author

gallois commented Oct 11, 2024

Ah! Fair point. What's the SOP in this case?

@JoseAlvarezSonos
Copy link

Hello, random question, any update on this?

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@bryantbiggs
Copy link
Member

we'll include it in #38

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 30, 2025
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Apr 10, 2025
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants