Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash: fix PS1=abc bash #23161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bash: fix PS1=abc bash #23161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/bash/etc-bash.bashrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ export HISTCONTROL=ignoreboth

# Default command line prompt.
PROMPT_DIRTRIM=2
if test -z "$(env | grep -w PS1)"; then
PS1='\[\e[0;32m\]\w\[\e[0m\] \[\e[0;97m\]\$\[\e[0m\] '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using [[ -v PS1 ]]1 instead to avoid the dependency on grep.

Suggested change
PS1='\[\e[0;32m\]\w\[\e[0m\] \[\e[0;97m\]\$\[\e[0m\] '
# Allow users to override $PS1 by passing it to the invocation of bash as an environment variable
[[ -v PS1 ]] || PS1='\[\e[0;32m\]\w\[\e[0m\] \[\e[0;97m\]\$\[\e[0m\] '

Footnotes

  1. https://man.archlinux.org/man/bash.1#CONDITIONAL_EXPRESSIONS:~:text=set%20builtin%20below.-,%2Dv%20varname,-True%20if%20the ↩

fi

# Handles nonexistent commands.
# If user has entered command which invokes non-available
Expand Down
Loading